Protect: Turn on waf module by default and add UI control for automatic rules #27663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add hook for interfacing with WAF data * [not verified] Add firewall-header component folder structure * [not verified] Apply header component code and styling * [not verified] Remove unneeded comments * [not verified] Update hasRequiredPlan check to useProtectData * [not verified] Fix typo * Add FirewallHeader component stories and improve portability * Add useWafData hook placeholder for moduleIsEnabled check * [not verified] Remove isModuleEnabled property in favor of currently available WAF data * [not verified] Remove console logging * [not verified] Add upgrade functionality to button * [not verified] Add Popover component for upgrade info * Fix styling issues * Create ConnectedFirewallHeader component and move all logic out of FirewallPage * Improve code efficiency * Update FirewallHeader status check, and checkout flow redirect URL * changelog * [not verified] Remove changelog entry * Change FirewallUrl to firewallUrl Co-authored-by: Nate Weller <nate.weller@automattic.com>
* Add hook for interfacing with WAF data * [not verified] Add firewall-header component folder structure * [not verified] Apply header component code and styling * [not verified] Remove unneeded comments * [not verified] Update hasRequiredPlan check to useProtectData * [not verified] Fix typo * Add FirewallHeader component stories and improve portability * Add useWafData hook placeholder for moduleIsEnabled check * [not verified] Remove isModuleEnabled property in favor of currently available WAF data * [not verified] Remove console logging * [not verified] Add upgrade functionality to button * [not verified] Add Popover component for upgrade info * Introduce and apply FirewallFooter component * Add central AdminSection component for better visualization * Improve spacing * [not verified] Apply initial run at StandaloneModeModal component * [not verified] Update Footer component to ScanFooter * [not verified] Improve StandaloneModeModal structure and styling * [not verified] Add FirewallFooter stories * [not verified] Update FirewallFooter to use SeventyFiveLayout * [not verified] Update styling comments * Fix styling issues * Create ConnectedFirewallHeader component and move all logic out of FirewallPage * Improve code efficiency * Update FirewallHeader status check, and checkout flow redirect URL * changelog * [not verified] Remove changelog entry * Change FirewallUrl to firewallUrl * Fix styling issues Co-authored-by: Nate Weller <nate.weller@automattic.com>
…27584) * Add upgrade prompt when WAF enabled but no rules access * Create separate internal component for upgrade prompt * Add story for on with no plan
* [not verified] Update WAF package to use portable Current_Plan over Jetpack_Plan for upgrade detection * Add jetpack-plans dependency direct to the WAF package * Add and use hasScan (over hasRulesAccess) check in Jetpack settings for the WAF module * Remove hasRulesAccess property from WAF module component * Remove has_rules_access method in favour of external plan checks
* [not verified] Add jetpack_waf_share_data option value to initial state, and use for checked value * [not verified] Remove comments * [not verified] Remove prior solution in favor of WAF endpoints solution and apply toggleShareData functionality to FirewallFooter checkbox * [not verified] Improve share data toggle functionality * [not verified] Improve code organization * [not verified] Add isEnabled check for share data section display * Remove wafShareData from initial state Co-authored-by: Nate Weller <nate.weller@automattic.com>
github-actions
bot
added
[Plugin] Protect
nateweller
changed the base branch from
add/protect-waf-phase-2
to
add/waf-automatic-rule-toggle
nateweller
changed the title
github-actions
bot
added
the
[Status] Needs Author Reply
Base automatically changed from
add/waf-automatic-rule-toggle
to
add/protect-waf-phase-2
December 19, 2022 19:19
github-actions
bot
added
[Plugin] Jetpack
|
Looks and works great! One minor styling issue: It appears that we can now remove both of the |
nateweller
approved these changes
Dec 19, 2022
nateweller
removed
[Status] Needs Team Review
[Status] Needs Author Reply
nateweller
deleted the
add/protect-waf-manual-vs-automatic-separation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds to the Protect UI, the ability to toggle on automatic and manual rules independent of one another.
Changes proposed in this Pull Request:
wafmodule is now enabled on plugin activation.wafpackage, and displays an error and prompt to re-enable the module if it is disabled (see screenshots).jetpack_waf_automatic_rulesoption instead of toggling the module.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
wafmodule is disabled.wafmodule is enabled.?foo=<script>)wafmodule, and ensure the firewall settings screen matches the screenshot below.Screenshots
Module disabled: